Enable Error Prone check: HidingField#12724
Merged
findepi merged 1 commit intotrinodb:masterfrom Jun 7, 2022
Merged
Conversation
This warning (now error) triggers when a subclass declares a field with the same name as a non-private (i.e. visible) field in a superclass. Usually this is a simple matter of redundancy, but there's one case where the field in superclass is actually not useful - it is only used in subclasses, and the assignment is trivial, so it's better declared in them instead.
kokosing
approved these changes
Jun 7, 2022
ssheikin
approved these changes
Jun 7, 2022
findepi
approved these changes
Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This warning (now error) triggers when a subclass declares a field with the same name as a non-private (i.e. visible) field in a superclass. Usually this is a simple matter of redundancy, but there's one case where the field in superclass is actually not useful - it is only used in subclasses, and the assignment is trivial, so it's better declared in them instead.
Static analysis improvement.
All over.
It improves code quality.
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: