Skip to content

Disallow null table version#12719

Merged
findepi merged 1 commit intotrinodb:masterfrom
findepi:findepi/as-of-null
Jun 9, 2022
Merged

Disallow null table version#12719
findepi merged 1 commit intotrinodb:masterfrom
findepi:findepi/as-of-null

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Jun 7, 2022

It probably does not have any practical use, so it is safer to just
disallow it, so that connectors do not have to check for (the rather
unexpected) null.

Note that NULL version (without a CAST) was not supported anyway.

@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 7, 2022

Currently, based on #12718

@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 9, 2022

I consulted this offline with @martint and @electrum as well

@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 9, 2022

rebasing after #12718 was merged

It probably does not have any practical use, so it is safer to just
disallow it, so that connectors do not have to check for (the rather
unexpected) null.

Note that `NULL` version (without a CAST) was not supported anyway.
@findepi findepi force-pushed the findepi/as-of-null branch from feb7919 to bc09834 Compare June 9, 2022 10:01
@findepi findepi merged commit f9022aa into trinodb:master Jun 9, 2022
@findepi findepi deleted the findepi/as-of-null branch June 9, 2022 10:01
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Jun 9, 2022
@github-actions github-actions bot added this to the 386 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

1 participant