Throw proper error for AS OF NULL#12718
Merged
findepi merged 5 commits intotrinodb:masterfrom Jun 9, 2022
Merged
Conversation
Add tests `StatementAnalyzer` validation for the `FOR ... AS OF ...` syntax.
Previously query would fail with "UNKNOWN is not a valid type", which can be confusing, since user did not specify "UNKNOWN" anywhere in the query.
findepi
added
the
no-release-notes
ebyhr
approved these changes
Jun 9, 2022
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously query would fail with "UNKNOWN is not a valid type", which
can be confusing, since user did not specify "UNKNOWN" anywhere in the
query.
This PR also adds some analyzer test coverage for time travel.