Switch from deprecated md5 to murmur3_128 hashing in RowToRowCast#12650
Merged
hashhar merged 1 commit intotrinodb:masterfrom Jun 3, 2022
Merged
Switch from deprecated md5 to murmur3_128 hashing in RowToRowCast#12650hashhar merged 1 commit intotrinodb:masterfrom
hashhar merged 1 commit intotrinodb:masterfrom
Conversation
wendigo
approved these changes
Jun 2, 2022
Contributor
|
Great, thanks @leveyja ! |
leveyja
force-pushed
the
leveyja/switch-hash-algo
branch
from
24de708 to
4a4c8ce
Compare
raunaqmorarka
approved these changes
Jun 3, 2022
hashhar
approved these changes
Jun 3, 2022
Member
|
Will merge once CI is done. |
Member
|
CI hit #10932 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up from #12631
Switch from deprecated md5 to mumur3_128 hashing in RowToRowCast when generating class names.
Refactoring
Core
Switching usages of deprecated hashing algorithm to preferred alternative
Related issues, pull requests, and links
#12631
Documentation
(:white_check_mark:) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(:white_check_mark:) No release notes entries required.
( ) Release notes entries required with the following suggested text: