Suppress warnings for MD5 and SHA1 hashing function usages#12631
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Jul 13, 2022
Merged
Suppress warnings for MD5 and SHA1 hashing function usages#12631ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
leveyja
force-pushed
the
leveyja/hashing-deprecation-warnings
branch
from
7821ef0 to
3ab574c
Compare
wendigo
approved these changes
Jun 1, 2022
electrum
reviewed
Jun 1, 2022
core/trino-main/src/main/java/io/trino/operator/scalar/RowToRowCast.java
Outdated
Show resolved
Hide resolved
electrum
approved these changes
Jun 1, 2022
electrum
reviewed
Jun 1, 2022
...tor-legacy/src/test/java/io/trino/plugin/raptor/legacy/storage/TestRaptorStorageManager.java
Outdated
Show resolved
Hide resolved
leveyja
force-pushed
the
leveyja/hashing-deprecation-warnings
branch
from
7de694a to
702c06c
Compare
leveyja
force-pushed
the
leveyja/hashing-deprecation-warnings
branch
from
702c06c to
875b8ed
Compare
Member
Author
|
Looks ready to merge - any suggestions who should give the final 👍 ? |
ebyhr
approved these changes
Jul 13, 2022
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Google Guava's
Hashing.md5()andHashing.sha1()are deprecated as insecure.We use them to provide md5/sha1 functions, and therefore the usage is merited.
This PR adds
@SuppressWarnings("deprecation")to the necessary usages to avoid spurious deprecation warnings.Refactoring
Code change to suppress build warnings / no functional changes (apart from 1 test)
Resolve build warnings
Related issues, pull requests, and links
Documentation
(:white_check_mark:) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(:white_check_mark:) No release notes entries required.
( ) Release notes entries required with the following suggested text: