Resolve all com.google.common.io.Files deprecation warnings

[leveyja]

Description

Google's Guava's Files#createTempDir and Files.copy and Files.write are all deprecated. This PR removes all usages of these deprecated methods.

Is this change a fix, improvement, new feature, refactoring, or other?

Refactoring

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Removal of deprecated method usages with appropriate replacements. No functional changes should manifest.

How would you describe this change to a non-technical end user or system administrator?

Spring-cleaning ;-)

Related issues, pull requests, and links

Documentation

(:white_check_mark:) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(:white_check_mark:) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

[wendigo]

Nice!

[wendigo]

Nice

[ebyhr]

CI is red.

Error:  Failures: 
Error:    TestShardRecovery.testShardRecoveryBackupChecksumMismatch:212 expected [/tmp/2732748991945657226/data/storage/c1/f1/c1f1441f-561c-497e-8dc3-d6317ab33dba.orc] but found [/tmp/2732748991945657226/backup/c1/f1/c1f1441f-561c-497e-8dc3-d6317ab33dba.orc]
Error:    TestShardRecovery.testShardRecoveryExistingFileChecksumMismatch:168 expected [/tmp/2903051290351253377/tmp12177291668773958702.tmp] but found [/tmp/2903051290351253377/backup/1a/8b/1a8bd803-f33a-482f-afc5-267d44aa6b78.orc]
Error:    TestShardRecovery.testShardRecoveryExistingFileSizeMismatch:130 expected [/tmp/2569217826565755780/tmp9491014867858533047.tmp] but found [/tmp/2569217826565755780/backup/19/82/19823723-95b6-4ef4-bb72-f72d8276ad7c.orc]

[leveyja]

CI is red.

Error:  Failures: 
Error:    TestShardRecovery.testShardRecoveryBackupChecksumMismatch:212 expected [/tmp/2732748991945657226/data/storage/c1/f1/c1f1441f-561c-497e-8dc3-d6317ab33dba.orc] but found [/tmp/2732748991945657226/backup/c1/f1/c1f1441f-561c-497e-8dc3-d6317ab33dba.orc]
Error:    TestShardRecovery.testShardRecoveryExistingFileChecksumMismatch:168 expected [/tmp/2903051290351253377/tmp12177291668773958702.tmp] but found [/tmp/2903051290351253377/backup/1a/8b/1a8bd803-f33a-482f-afc5-267d44aa6b78.orc]
Error:    TestShardRecovery.testShardRecoveryExistingFileSizeMismatch:130 expected [/tmp/2569217826565755780/tmp9491014867858533047.tmp] but found [/tmp/2569217826565755780/backup/19/82/19823723-95b6-4ef4-bb72-f72d8276ad7c.orc]

Thanks @ebyhr - I switched Files.equals to .equals assuming the content was meant to be equal - File.equals(File) tests the abstract path names are equal (which they're not). I'll fix up those mistakes - cheers for spotting it!

[leveyja]

1 failing test suite due to timeout - https://github.com/trinodb/trino/runs/6720470622?check_suite_focus=true - will rerun.

[leveyja]

1 check was cancelled(?) re-running

[leveyja]

https://github.com/trinodb/trino/runs/6727864278?check_suite_focus=true - failed/cancelled due to timeout (54 minutes running tests). Will re-run...

[ebyhr]

Can we update .mvn/modernizer/violations.xml?

[ebyhr]

This change looks unrelated. Could you separate a commit or update the commit body?

[leveyja]

Well spotted, I don't recall removing it (it may have been when I was trying a POC to remove all the warnings, and this got grouped into the com.google ones when I separated the commits).

[leveyja]

Can we update .mvn/modernizer/violations.xml?

Ideally we don't have to update anything, we just need to build w/-Xlint:deprecation and all present and future deprecations will be visible to us (without us updating any xml files). We can combine this w/-Werror to fail the build when any upgrade introduces new deprecated methods (and be warned to change our usages).

Maybe as part of a coordinated plan to remove deprecations adding them to violations.xml would make sense.
See #12628 for how to generate the list of existing deprecations (1300+, 800 of them io.trino / our own usages of our own deprecated methods).

[findepi]

I'd prefer UTF-8 to be explicit.
i know the Files.writeString uses UTF-8 by default, but providing it explicitly also conveys the intent.

[findepi]

(just rebased)