Add maven profile for -Xlint:deprecation compiler option

[leveyja]

Description

Adding maven profile to add -Xlint:deprecation compiler option.
Compiling with ./mvnw [...] -Pdeprecation will warn about deprecated method and class usages.

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Build compiler change to enable verbose deprecation warnings during compilation.

How would you describe this change to a non-technical end user or system administrator?

Adding a build option to enabling warnings to be printed during the build.

Related issues, pull requests, and links

Documentation

(:white_check_mark:) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(:white_check_mark:) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

[wendigo]

Thanks!

[leveyja]

Failed due to TestIcebergSparkCompatibility > testTrinoReadsSparkRowLevelDeletesWithRowTypes(0: ORC, 1: AVRO) [groups: profile_specific_tests, iceberg]
Will re-run

[leveyja]

Looks ready to merge - any suggestions who should give the final 👍 ?

[hashhar]

Unused profiles aren't useful - since people won't generally run with this profile.

Maybe you can add a new job to ci.yml that prints out a deprecation log with using this profile for running maven-checks.

But I think #12629 is the way to go instead - i.e. fix/disable current deprecations and then enable -Xlint:deprecation -Werror in the maven-checks job.

[leveyja]

Unused profiles aren't useful

It could be added to the errorprone-compiler profile instead? I was trying to keep it clean/simple by adding a separate profile (and anyone can read the pom.xml and understand what the profile does, so it's there to be used).
(Also, nit: I would use it - so it wouldn't be unused ;-) )

[mosabua]

Is this still valid or did we implement a better approach already @hashhar @leveyja @wendigo

[github-actions]

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua