Skip to content

Add iceberg.table-statistics-enabled property in Iceberg doc #12593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
electrum merged 2 commits into from
Jun 10, 2022
Merged

Add iceberg.table-statistics-enabled property in Iceberg doc #12593

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cb96c0
Add `ORC format configuration` module in Iceberg doc
polaris6 May 30, 2022
384e4e1
Add `iceberg.table-statistics-enabled` property in Iceberg doc
polaris6 May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion docs/src/main/sphinx/connector/iceberg.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ General configuration
These configuration properties are independent of which catalog implementation
is used.

.. list-table:: Iceberg configuration properties
.. list-table:: Iceberg general configuration properties
:widths: 30, 58, 12
:header-rows: 1

Expand All @@ -110,6 +110,28 @@ is used.
* - ``iceberg.max-partitions-per-writer``
- Maximum number of partitions handled per writer.
- 100
* - ``iceberg.table-statistics-enabled``
- Enables :doc:`/optimizer/statistics`. The equivalent
:doc:`catalog session property </sql/set-session>`
is ``statistics_enabled`` for session specific use.
Set to ``false`` to disable statistics. Disabling statistics
means that :doc:`/optimizer/cost-based-optimizations` can
not make smart decisions about the query plan.
- ``true``

ORC format configuration
Copy link
Copy Markdown
Member

@raunaqmorarka raunaqmorarka May 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would drop the first commit because the orc prefix in the property name makes it fairly obvious that the config is ORC specific.

Copy link
Copy Markdown

@zhengxingmao zhengxingmao May 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To maintain backward compatibility, the same parameters are used. For details, please refer to the following link.
#11732 (comment)

Copy link
Copy Markdown
Member Author

@polaris6 polaris6 May 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will not rename hive.orc.bloom-filters.enabled.

^^^^^^^^^^^^^^^^^^^^^^^^

The following properties are used to configure the read and write operations
with ORC files performed by the Iceberg connector.
Comment thread
polaris6 marked this conversation as resolved.

.. list-table:: ORC format configuration properties
:widths: 30, 58, 12
:header-rows: 1

* - Property name
- Description
- Default
* - ``hive.orc.bloom-filters.enabled``
- Enable bloom filters for predicate pushdown.
- ``false``
Expand Down