Skip to content

Add iceberg.table-statistics-enabled property in Iceberg doc#12593

Merged
electrum merged 2 commits intotrinodb:masterfrom
polaris6:add_statistics_enabled_doc
Jun 10, 2022
Merged

Add iceberg.table-statistics-enabled property in Iceberg doc#12593
electrum merged 2 commits intotrinodb:masterfrom
polaris6:add_statistics_enabled_doc

Conversation

@polaris6
Copy link
Copy Markdown
Member

@polaris6 polaris6 commented May 30, 2022

Description

Add iceberg.table-statistics-enabled property in Iceberg doc.

Refer to hive.table-statistics-enabled in Hive:
https://trino.io/docs/current/connector/hive.html#hive-configuration-properties

This RR also adds ORC format configuration properties module, refer to: https://trino.io/docs/current/connector/hive.html#orc-format-configuration-properties. Because hive.orc.bloom-filters.enabled in Iceberg is specific to orc format.

Related issues, pull requests, and links

Fixes #12589

Documentation

(x) Sufficient documentation is included in this PR.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label May 30, 2022
@github-actions github-actions bot added the docs label May 30, 2022
@polaris6
Copy link
Copy Markdown
Member Author

polaris6 commented May 30, 2022

In addition, does hive.orc.bloom-filters.enabled needs to be renamed to iceberg.orc.bloom-filters.enabled? I'll update this property If needed.
cc: @findepi @alexjo2144 @raunaqmorarka
image

@polaris6 polaris6 changed the title Add statistics enabled doc Add iceberg.table-statistics-enabled property in Iceberg doc May 30, 2022
@polaris6 polaris6 changed the title Add iceberg.table-statistics-enabled property in Iceberg doc Add iceberg.table-statistics-enabled property in Iceberg doc May 30, 2022
@findepi findepi requested review from hashhar and mosabua May 30, 2022 09:07
- Maximum number of partitions handled per writer.
- 100

ORC format configuration
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would drop the first commit because the orc prefix in the property name makes it fairly obvious that the config is ORC specific.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To maintain backward compatibility, the same parameters are used. For details, please refer to the following link.
#11732 (comment)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will not rename hive.orc.bloom-filters.enabled.

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it ... its good to break up these long tables into meaningful topics.

@polaris6
Copy link
Copy Markdown
Member Author

polaris6 commented Jun 1, 2022

Hi @hashhar, could you please help me review this PR when you have time? Thank you very much!

@polaris6 polaris6 requested review from colebow and przemekak June 9, 2022 02:18
Copy link
Copy Markdown
Member

@colebow colebow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to snag a maintainer's attention to get this merged.

@electrum electrum merged commit c0e5e97 into trinodb:master Jun 10, 2022
@electrum
Copy link
Copy Markdown
Member

Thanks!

@github-actions github-actions bot added this to the 386 milestone Jun 10, 2022
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Jun 10, 2022

Well done @polaris6 and thank you for your contribution.

@polaris6 polaris6 deleted the add_statistics_enabled_doc branch June 16, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Add iceberg.table-statistics-enabled property in Iceberg doc

6 participants