Edit fault tolerant execution docs for style and readability#12549
Merged
losipiuk merged 1 commit intotrinodb:masterfrom May 25, 2022
Merged
Edit fault tolerant execution docs for style and readability#12549losipiuk merged 1 commit intotrinodb:masterfrom
losipiuk merged 1 commit intotrinodb:masterfrom
Conversation
jhlodin
force-pushed
the
jl/fte-azure-edits
branch
2 times, most recently
from
0b53ae7 to
5aa7193
Compare
jhlodin
force-pushed
the
jl/fte-azure-edits
branch
from
5aa7193 to
4d61158
Compare
mosabua
approved these changes
May 25, 2022
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Looks good and fixes some critical errors..
jhlodin
changed the title
Member
|
Prior to this PR the abfs and gcs code snippets were in the wrong sections .. |
losipiuk
approved these changes
May 25, 2022
linzebing
reviewed
May 25, 2022
| that stores spooled data in a specified location, either an S3-compatible | ||
| storage system or a local filesystem. | ||
| that stores spooled data in a specified location, such as an S3-compatible | ||
| storage system, Google Cloud Storage (GCS), or a local filesystem. |
Contributor
Author
There was a problem hiding this comment.
I considered that, but it doesn't seem necessary given that this sentence just talks about example filesystems. The sections below being a more complete list is sufficient.
Contributor
Author
There was a problem hiding this comment.
Maybe as we add more we could turn this into a complete (bulleted) list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up edits to the Azure Blob Storage FTE PR
Improvement
Documentation
Help make the fault tolerant execution easier to read and similarly-written to other Trino documentation
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: