Skip to content

Add docs on configuring Azure/GCS for exchange spooling#12472

Merged
arhimondr merged 1 commit intotrinodb:masterfrom
linzebing:spooling-docs
May 24, 2022
Merged

Add docs on configuring Azure/GCS for exchange spooling#12472
arhimondr merged 1 commit intotrinodb:masterfrom
linzebing:spooling-docs

Conversation

@linzebing
Copy link
Member

@linzebing linzebing commented May 19, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

docs

How would you describe this change to a non-technical end user or system administrator?

Related issues, pull requests, and links

Addresses #12467, depends on #12360

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 19, 2022
@linzebing linzebing requested a review from colebow May 19, 2022 05:21
@github-actions github-actions bot added the docs label May 19, 2022
@linzebing linzebing requested review from arhimondr and losipiuk May 19, 2022 05:22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not get the otherwise, you need to configure the key path to your GCS credential file part. Don't we always need to do that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, if you GCS deployment is associated with a service account that has access to the spooling bucket, then default authentication will just work out of the box.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean GCP deployment, right? Makes sense.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
If using Azure Blob Storage, it is recommended to configure a lifecycle policy for your
If you are using Azure Blob Storage, it is recommended to configure a lifecycle policy for your

Comment on lines 443 to 444
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably move this and the other two near-identical statements to above the AWS S3 section and only say it once for all three, that way we're not repeating the same thing.

Comment on lines 412 to 413
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
AWS S3
~~~~~~~~~~~~~~~~~
AWS S3
~~~~~~

LGTM, though I missed this

@arhimondr arhimondr merged commit fcfd210 into trinodb:master May 24, 2022
@github-actions github-actions bot added this to the 382 milestone May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants