Delay converting labels to Block in Prometheus#12510
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Jul 11, 2022
Merged
Conversation
ebyhr
force-pushed
the
ebi/prometheus-fix-aggreagtion
branch
from
8c3bbd7 to
f7098a1
Compare
This change fixes aggregation query failure without labels column. Previously, the record cursor always tried to get the label column type even though the column handle is empty.
ebyhr
force-pushed
the
ebi/prometheus-fix-aggreagtion
branch
from
f7098a1 to
34ad395
Compare
Praveen2112
approved these changes
Jul 11, 2022
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documentation
(x) No documentation is needed.
Release notes
(x) Release notes entries required with the following suggested text: