Skip to content

Fix failure when accessing without labels column in Prometheus#12473

Closed
Emor-nj wants to merge 1 commit intotrinodb:masterfrom
Emor-nj:dev
Closed

Fix failure when accessing without labels column in Prometheus#12473
Emor-nj wants to merge 1 commit intotrinodb:masterfrom
Emor-nj:dev

Conversation

@Emor-nj
Copy link
Copy Markdown
Member

@Emor-nj Emor-nj commented May 19, 2022

Description

Fix Prometheus connector always requires labels column

Related issues, pull requests, and links

Fixes #12301

Documentation

Release notes

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented May 19, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check CI failure.

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented May 20, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@Emor-nj
Copy link
Copy Markdown
Member Author

Emor-nj commented May 20, 2022

Please check CI failure.

lack the dependency of jsr305

@Emor-nj Emor-nj closed this May 20, 2022
@Emor-nj Emor-nj reopened this May 20, 2022
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented May 20, 2022

Re-triggered CI.

@Emor-nj
Copy link
Copy Markdown
Member Author

Emor-nj commented May 27, 2022

@cla-bot check

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented May 27, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented May 27, 2022

The cla-bot has been summoned, and re-checked this pull request!

@Emor-nj
Copy link
Copy Markdown
Member Author

Emor-nj commented Jun 7, 2022

it's solved by #12510

@Emor-nj Emor-nj closed this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Prometheus connector always requires labels column

2 participants