Skip to content

Add argument-less builder methods for boolean values #12476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasiafi merged 1 commit into from
May 23, 2022
+10 −6
Merged

Add argument-less builder methods for boolean values #12476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions core/trino-spi/src/main/java/io/trino/spi/ptf/TableArgumentSpecification.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,21 +64,21 @@ public Builder name(String name)
return this;
}

public Builder rowSemantics(boolean rowSemantics)
public Builder rowSemantics()
{
this.rowSemantics = rowSemantics;
this.rowSemantics = true;
return this;
}

public Builder pruneWhenEmpty(boolean pruneWhenEmpty)
public Builder pruneWhenEmpty()
{
this.pruneWhenEmpty = pruneWhenEmpty;
this.pruneWhenEmpty = true;
return this;
}

public Builder passThroughColumns(boolean passThroughColumns)
public Builder passThroughColumns()
{
this.passThroughColumns = passThroughColumns;
this.passThroughColumns = true;
return this;
}

Expand Down
4 changes: 4 additions & 0 deletions core/trino-spi/src/test/java/io/trino/spi/TestSpiBackwardCompatibility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ public class TestSpiBackwardCompatibility
"Field: public java.util.List<io.trino.spi.predicate.Range> io.trino.spi.predicate.BenchmarkSortedRangeSet$Data.ranges"))
.put("377", ImmutableSet.of(
"Constructor: public io.trino.spi.memory.MemoryPoolInfo(long,long,long,java.util.Map<io.trino.spi.QueryId, java.lang.Long>,java.util.Map<io.trino.spi.QueryId, java.util.List<io.trino.spi.memory.MemoryAllocation>>,java.util.Map<io.trino.spi.QueryId, java.lang.Long>)"))
.put("382", ImmutableSet.of(
"Method: public io.trino.spi.ptf.TableArgumentSpecification$Builder io.trino.spi.ptf.TableArgumentSpecification$Builder.rowSemantics(boolean)",
"Method: public io.trino.spi.ptf.TableArgumentSpecification$Builder io.trino.spi.ptf.TableArgumentSpecification$Builder.pruneWhenEmpty(boolean)",
"Method: public io.trino.spi.ptf.TableArgumentSpecification$Builder io.trino.spi.ptf.TableArgumentSpecification$Builder.passThroughColumns(boolean)"))
.buildOrThrow();

@Test
Expand Down