Add argument-less builder methods for boolean values#12476
Add argument-less builder methods for boolean values#12476kasiafi merged 1 commit intotrinodb:masterfrom
Conversation
|
@findepi how do I deal with SPI backwards compatibility assertions? Should I deprecate the old methods instead of remove? I'd rather remove them right away, since this is a new feature with no usage so far. |
i think so
You'd need to add exclusion to |
|
i'm fine either way |
The TableArgumentSpecification builder is part of SPI for declaring Table Functions. It assumes default values for boolean table argument properties. It is meant to provide the easiest and most intuitive way of declaring TableFunctions.
The feature is experimental and it’s not being used by anyone, so no point in trying to keep it compatible. Let’s just remove it. I expect we’ll have to make a few more changes as we continue implementing the rest of the functionality to be able to execute the functions. |
|
@findepi I removed the old methods and added exclusion. Is it ready to go? |
The TableArgumentSpecification builder is part of SPI for declaring
Table Functions. It assumes default values for boolean table argument
properties, and allows to change them using argument-less methods.
It is meant to provide the easiest and most intuitive way of declaring
Table Functions.
This is a SPI change.
No documentation needed.