Skip to content

Minor cleanup of WindowNode constructor #12273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopel39 merged 1 commit into from
May 16, 2022
Merged

Minor cleanup of WindowNode constructor #12273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions core/trino-main/src/main/java/io/trino/sql/planner/plan/WindowNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,18 @@ public WindowNode(
requireNonNull(specification, "specification is null");
requireNonNull(windowFunctions, "windowFunctions is null");
requireNonNull(hashSymbol, "hashSymbol is null");
checkArgument(specification.getPartitionBy().containsAll(prePartitionedInputs), "prePartitionedInputs must be contained in partitionBy");
requireNonNull(prePartitionedInputs, "prePartitionedInputs is null");
// Make the defensive copy eagerly, so it can be used for both the validation checks and assigned directly to the field afterwards
prePartitionedInputs = ImmutableSet.copyOf(prePartitionedInputs);

ImmutableSet<Symbol> partitionBy = ImmutableSet.copyOf(specification.getPartitionBy());
Optional<OrderingScheme> orderingScheme = specification.getOrderingScheme();
checkArgument(partitionBy.containsAll(prePartitionedInputs), "prePartitionedInputs must be contained in partitionBy");
checkArgument(preSortedOrderPrefix == 0 || (orderingScheme.isPresent() && preSortedOrderPrefix <= orderingScheme.get().getOrderBy().size()), "Cannot have sorted more symbols than those requested");
checkArgument(preSortedOrderPrefix == 0 || ImmutableSet.copyOf(prePartitionedInputs).equals(ImmutableSet.copyOf(specification.getPartitionBy())), "preSortedOrderPrefix can only be greater than zero if all partition symbols are pre-partitioned");
checkArgument(preSortedOrderPrefix == 0 || partitionBy.equals(prePartitionedInputs), "preSortedOrderPrefix can only be greater than zero if all partition symbols are pre-partitioned");

this.source = source;
this.prePartitionedInputs = ImmutableSet.copyOf(prePartitionedInputs);
this.prePartitionedInputs = prePartitionedInputs;
this.specification = specification;
this.windowFunctions = ImmutableMap.copyOf(windowFunctions);
this.hashSymbol = hashSymbol;
Expand Down