Minor cleanup of WindowNode constructor#12273
Merged
sopel39 merged 1 commit intotrinodb:masterfrom May 16, 2022
Merged
Conversation
findepi
requested review from
raunaqmorarka and
sopel39
and removed request for
findepi
raunaqmorarka
approved these changes
May 10, 2022
Member
raunaqmorarka
left a comment
raunaqmorarka
left a comment
There was a problem hiding this comment.
Please add the PR description to the commit message.
core/trino-main/src/main/java/io/trino/sql/planner/plan/WindowNode.java
Outdated
Show resolved
Hide resolved
pettyjamesm
force-pushed
the
cleanup-window-node-constructor
branch
3 times, most recently
from
d4477f2 to
8a31587
Compare
pettyjamesm
force-pushed
the
cleanup-window-node-constructor
branch
2 times, most recently
from
ee8f897 to
d69ed2e
Compare
Member
Author
|
Test failures appear unrelated and have been seemingly random throughout the day. |
Minor cleanup to avoid redundant copies during validation and field assignment in the WindowNode constructor. Also changes a usage of List#containsAll to the Set#containsAll equivalent.
pettyjamesm
force-pushed
the
cleanup-window-node-constructor
branch
from
d69ed2e to
4f9eea6
Compare
Member
|
Failed due to #12415 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor cleanup to avoid redundant copies during validation and field assignment in the
WindowNodeconstructor. Also changes a usage ofList#containsAllto theSet#containsAllequivalent.Minor refactor.
Core engine.
This change should not need to be described to non-technical users or administrators.
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: