Skip to content

Add access control for functions based on full qualified name #12241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasiafi merged 1 commit into from
May 5, 2022
Merged

Add access control for functions based on full qualified name #12241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/trino-main/src/main/java/io/trino/security/AccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,13 @@ void checkCanRevokeRoles(SecurityContext context,
*/
void checkCanExecuteFunction(SecurityContext context, String functionName);
Copy link
Copy Markdown
Member

@kokosing kokosing May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we deprecate or remove this one?

Copy link
Copy Markdown
Member

@findepi findepi May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. This will be possible only after all functions gain some namespace, which i guess will happen rather sooner than later, but did not happen yet.


/**
* Check if identity is allowed to execute function
*
* @throws AccessDeniedException if not allowed
*/
void checkCanExecuteFunction(SecurityContext context, QualifiedObjectName functionName);

/**
* Check if identity is allowed to execute given table procedure on given table
*
Expand Down
16 changes: 16 additions & 0 deletions core/trino-main/src/main/java/io/trino/security/AccessControlManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,6 +1134,22 @@ public void checkCanExecuteFunction(SecurityContext context, String functionName
systemAuthorizationCheck(control -> control.checkCanExecuteFunction(context.toSystemSecurityContext(), functionName));
}

@Override
public void checkCanExecuteFunction(SecurityContext securityContext, QualifiedObjectName functionName)
{
requireNonNull(securityContext, "securityContext is null");
requireNonNull(functionName, "functionName is null");

checkCanAccessCatalog(securityContext, functionName.getCatalogName());

systemAuthorizationCheck(control -> control.checkCanExecuteFunction(securityContext.toSystemSecurityContext(), functionName.asCatalogSchemaRoutineName()));

catalogAuthorizationCheck(
functionName.getCatalogName(),
securityContext,
(control, context) -> control.checkCanExecuteFunction(context, functionName.asSchemaRoutineName()));
}

@Override
public void checkCanExecuteTableProcedure(SecurityContext securityContext, QualifiedObjectName tableName, String procedureName)
{
Expand Down
5 changes: 5 additions & 0 deletions core/trino-main/src/main/java/io/trino/security/AllowAllAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,11 @@ public void checkCanExecuteFunction(SecurityContext context, String functionName
{
}

@Override
public void checkCanExecuteFunction(SecurityContext context, QualifiedObjectName functionName)
{
}

@Override
public void checkCanExecuteTableProcedure(SecurityContext context, QualifiedObjectName tableName, String procedureName)
{
Expand Down
6 changes: 6 additions & 0 deletions core/trino-main/src/main/java/io/trino/security/DenyAllAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,12 @@ public void checkCanExecuteFunction(SecurityContext context, String functionName
denyExecuteFunction(functionName);
}

@Override
public void checkCanExecuteFunction(SecurityContext context, QualifiedObjectName functionName)
{
denyExecuteFunction(functionName.toString());
}

@Override
public void checkCanExecuteTableProcedure(SecurityContext context, QualifiedObjectName tableName, String procedureName)
{
Expand Down
6 changes: 6 additions & 0 deletions core/trino-main/src/main/java/io/trino/security/ForwardingAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,12 @@ public void checkCanExecuteFunction(SecurityContext context, String functionName
delegate().checkCanExecuteFunction(context, functionName);
}

@Override
public void checkCanExecuteFunction(SecurityContext context, QualifiedObjectName functionName)
{
delegate().checkCanExecuteFunction(context, functionName);
}

@Override
public void checkCanExecuteTableProcedure(SecurityContext context, QualifiedObjectName tableName, String procedureName)
{
Expand Down
7 changes: 7 additions & 0 deletions core/trino-main/src/main/java/io/trino/security/InjectedConnectorAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,13 @@ public void checkCanExecuteTableProcedure(ConnectorSecurityContext context, Sche
procedure);
}

@Override
public void checkCanExecuteFunction(ConnectorSecurityContext context, SchemaRoutineName function)
{
checkArgument(context == null, "context must be null");
accessControl.checkCanExecuteFunction(securityContext, new QualifiedObjectName(catalogName, function.getSchemaName(), function.getRoutineName()));
}

@Override
public List<ViewExpression> getRowFilters(ConnectorSecurityContext context, SchemaTableName tableName)
{
Expand Down
3 changes: 3 additions & 0 deletions core/trino-main/src/main/java/io/trino/testing/AllowAllAccessControlManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,9 @@ public void checkCanExecuteProcedure(SecurityContext context, QualifiedObjectNam
@Override
public void checkCanExecuteFunction(SecurityContext context, String functionName) {}

@Override
public void checkCanExecuteFunction(SecurityContext context, QualifiedObjectName functionName) {}

@Override
public void checkCanExecuteTableProcedure(SecurityContext context, QualifiedObjectName tableName, String procedureName) {}
}
11 changes: 11 additions & 0 deletions core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import static io.trino.spi.security.AccessDeniedException.denyDropSchema;
import static io.trino.spi.security.AccessDeniedException.denyDropTable;
import static io.trino.spi.security.AccessDeniedException.denyDropView;
import static io.trino.spi.security.AccessDeniedException.denyExecuteFunction;
import static io.trino.spi.security.AccessDeniedException.denyExecuteProcedure;
import static io.trino.spi.security.AccessDeniedException.denyExecuteTableProcedure;
import static io.trino.spi.security.AccessDeniedException.denyGrantRoles;
Expand Down Expand Up @@ -596,6 +597,16 @@ default void checkCanExecuteTableProcedure(ConnectorSecurityContext context, Sch
denyExecuteTableProcedure(tableName.toString(), procedure);
}

/**
* Check if identity is allowed to execute function.
*
* @throws io.trino.spi.security.AccessDeniedException if not allowed
*/
default void checkCanExecuteFunction(ConnectorSecurityContext context, SchemaRoutineName function)
{
denyExecuteFunction(function.toString());
}

/**
* Get a row filter associated with the given table and identity.
* <p>
Expand Down
10 changes: 10 additions & 0 deletions core/trino-spi/src/main/java/io/trino/spi/security/SystemAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,16 @@ default void checkCanExecuteFunction(SystemSecurityContext systemSecurityContext
denyExecuteFunction(functionName);
}

/**
* Check if identity is allowed to execute the specified function
*
* @throws AccessDeniedException if not allowed
*/
default void checkCanExecuteFunction(SystemSecurityContext systemSecurityContext, CatalogSchemaRoutineName functionName)
{
denyExecuteFunction(functionName.toString());
}

/**
* Check if identity is allowed to execute the specified table procedure on specified table
*
Expand Down
8 changes: 8 additions & 0 deletions ...src/main/java/io/trino/plugin/base/classloader/ClassLoaderSafeConnectorAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,14 @@ public void checkCanExecuteTableProcedure(ConnectorSecurityContext context, Sche
}
}

@Override
public void checkCanExecuteFunction(ConnectorSecurityContext context, SchemaRoutineName function)
{
try (ThreadContextClassLoader ignored = new ThreadContextClassLoader(classLoader)) {
delegate.checkCanExecuteFunction(context, function);
}
}

@Override
public List<ViewExpression> getRowFilters(ConnectorSecurityContext context, SchemaTableName tableName)
{
Expand Down
5 changes: 5 additions & 0 deletions ...ino-plugin-toolkit/src/main/java/io/trino/plugin/base/security/AllowAllAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,11 @@ public void checkCanExecuteTableProcedure(ConnectorSecurityContext context, Sche
{
}

@Override
public void checkCanExecuteFunction(ConnectorSecurityContext context, SchemaRoutineName function)
{
}

@Override
public List<ViewExpression> getRowFilters(ConnectorSecurityContext context, SchemaTableName tableName)
{
Expand Down
5 changes: 5 additions & 0 deletions ...ugin-toolkit/src/main/java/io/trino/plugin/base/security/AllowAllSystemAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,11 @@ public void checkCanExecuteFunction(SystemSecurityContext systemSecurityContext,
{
}

@Override
public void checkCanExecuteFunction(SystemSecurityContext systemSecurityContext, CatalogSchemaRoutineName functionName)
{
}

@Override
public void checkCanExecuteTableProcedure(SystemSecurityContext systemSecurityContext, CatalogSchemaTableName table, String procedure)
{
Expand Down
5 changes: 5 additions & 0 deletions ...no-plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,11 @@ public void checkCanExecuteTableProcedure(ConnectorSecurityContext context, Sche
{
}

@Override
public void checkCanExecuteFunction(ConnectorSecurityContext context, SchemaRoutineName function)
{
}

@Override
public List<ViewExpression> getRowFilters(ConnectorSecurityContext context, SchemaTableName tableName)
{
Expand Down
5 changes: 5 additions & 0 deletions ...gin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedSystemAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,6 +938,11 @@ public void checkCanExecuteFunction(SystemSecurityContext systemSecurityContext,
{
}

@Override
public void checkCanExecuteFunction(SystemSecurityContext systemSecurityContext, CatalogSchemaRoutineName functionName)
{
}

@Override
public void checkCanExecuteTableProcedure(SystemSecurityContext systemSecurityContext, CatalogSchemaTableName table, String procedure)
{
Expand Down
6 changes: 6 additions & 0 deletions ...toolkit/src/main/java/io/trino/plugin/base/security/ForwardingConnectorAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,12 @@ public void checkCanExecuteTableProcedure(ConnectorSecurityContext context, Sche
delegate().checkCanExecuteTableProcedure(context, tableName, procedure);
}

@Override
public void checkCanExecuteFunction(ConnectorSecurityContext context, SchemaRoutineName function)
{
delegate().checkCanExecuteFunction(context, function);
}

@Override
public Optional<ViewExpression> getRowFilter(ConnectorSecurityContext context, SchemaTableName tableName)
{
Expand Down
6 changes: 6 additions & 0 deletions ...in-toolkit/src/main/java/io/trino/plugin/base/security/ForwardingSystemAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,12 @@ public void checkCanExecuteFunction(SystemSecurityContext systemSecurityContext,
delegate().checkCanExecuteFunction(systemSecurityContext, functionName);
}

@Override
public void checkCanExecuteFunction(SystemSecurityContext systemSecurityContext, CatalogSchemaRoutineName functionName)
{
delegate().checkCanExecuteFunction(systemSecurityContext, functionName);
}

@Override
public void checkCanExecuteTableProcedure(SystemSecurityContext systemSecurityContext, CatalogSchemaTableName table, String procedure)
{
Expand Down
5 changes: 5 additions & 0 deletions plugin/trino-hive/src/main/java/io/trino/plugin/hive/security/LegacyAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,11 @@ public void checkCanExecuteTableProcedure(ConnectorSecurityContext context, Sche
{
}

@Override
public void checkCanExecuteFunction(ConnectorSecurityContext context, SchemaRoutineName function)
{
}

@Override
public List<ViewExpression> getRowFilters(ConnectorSecurityContext context, SchemaTableName tableName)
{
Expand Down
5 changes: 5 additions & 0 deletions plugin/trino-hive/src/main/java/io/trino/plugin/hive/security/SqlStandardAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,11 @@ public void checkCanExecuteTableProcedure(ConnectorSecurityContext context, Sche
}
}

@Override
public void checkCanExecuteFunction(ConnectorSecurityContext context, SchemaRoutineName function)
{
}

@Override
public List<ViewExpression> getRowFilters(ConnectorSecurityContext context, SchemaTableName tableName)
{
Expand Down