Add access control for functions based on full qualified name#12241
Merged
kasiafi merged 1 commit intotrinodb:masterfrom May 5, 2022
Merged
Add access control for functions based on full qualified name#12241kasiafi merged 1 commit intotrinodb:masterfrom
kasiafi merged 1 commit intotrinodb:masterfrom
Conversation
Praveen2112
approved these changes
May 5, 2022
kokosing
reviewed
May 5, 2022
| @@ -525,6 +525,13 @@ void checkCanRevokeRoles(SecurityContext context, | |||
| */ | |||
| void checkCanExecuteFunction(SecurityContext context, String functionName); | |||
Member
There was a problem hiding this comment.
Should we deprecate or remove this one?
Member
There was a problem hiding this comment.
No. This will be possible only after all functions gain some namespace, which i guess will happen rather sooner than later, but did not happen yet.
kokosing
approved these changes
May 5, 2022
Member
|
I assume this does NOT need release notes entry. Looks like it is enabling features later.. |
Member
Author
@mosabua that's right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows providing access control for Table Functions (#11336) both on system and connector level.
Requested by #11336 (comment)