Fix Dev Guide references to new locations#11906
Conversation
|
@aakashnand, thanks for the suggestion to link to the referenced code, but even more for doing the work! I bravely clicked the Commit changes buttons here in GitHub. Can you SQUASH and merge? |
|
@Ordinant sure will do it today. |
5b8f3c7 to
aeef2f9
Compare
|
@aakashnand, I squashed all commits to one. Thanks for your help! |
|
@mosabua I thought it would be more better user experience to directly click the links rather than going to repo and find that file manually |
I understand .. but I also think I disagree .. if you are reading this dev guide you would typically have the whole codebase open in an IDE already and just jump to the class with shortcut key... at least thtats what I would do. |
hashhar
left a comment
There was a problem hiding this comment.
Let's remove links to source code since they are easy to break while the class names or module names can generally be searched for and they'll lead you to correct place even if things have been renamed.
Rest of it looks good.
aeef2f9 to
f9f9f82
Compare
f9f9f82 to
473f8dd
Compare
Description
The Developer Guide chapter has a few references to sub-projects “at the root of the Trino source tree”. But since the reorganization of that tree, these references are one layer off. Also added one missing Oxford comma.
Fix.
Docs only.
Doc correction.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: