Skip to content

Improve IN list performance in ExpressionInterpreter #11902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopel39 merged 3 commits into from
Apr 14, 2022
Merged

Improve IN list performance in ExpressionInterpreter #11902

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25bb913
Fix formatting
sopel39 Apr 11, 2022
5f168dc
Skip interpreting of literals when IN value is unbounded
sopel39 Apr 14, 2022
02ea077
Do not use inListCache when value is an expression
sopel39 Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 34 additions & 24 deletions core/trino-main/src/main/java/io/trino/sql/planner/ExpressionInterpreter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,27 +602,29 @@ protected Object visitInPredicate(InPredicate node, Object context)
return null;
}

Set<?> set = inListCache.get(valueList);

// We use the presence of the node in the map to indicate that we've already done
// the analysis below. If the value is null, it means that we can't apply the HashSet
// optimization
if (!inListCache.containsKey(valueList)) {
if (valueList.getValues().stream().allMatch(Literal.class::isInstance) &&
valueList.getValues().stream().noneMatch(NullLiteral.class::isInstance)) {
Set<Object> objectSet = valueList.getValues().stream().map(expression -> processWithExceptionHandling(expression, context)).collect(Collectors.toSet());
Type type = type(node.getValue());
set = FastutilSetHelper.toFastutilHashSet(
objectSet,
type,
plannerContext.getFunctionManager().getScalarFunctionInvoker(metadata.resolveOperator(session, HASH_CODE, ImmutableList.of(type)), simpleConvention(FAIL_ON_NULL, NEVER_NULL)).getMethodHandle(),
plannerContext.getFunctionManager().getScalarFunctionInvoker(metadata.resolveOperator(session, EQUAL, ImmutableList.of(type, type)), simpleConvention(NULLABLE_RETURN, NEVER_NULL, NEVER_NULL)).getMethodHandle());
if (!(value instanceof Expression)) {
Set<?> set = inListCache.get(valueList);

// We use the presence of the node in the map to indicate that we've already done
// the analysis below. If the value is null, it means that we can't apply the HashSet
// optimization
if (!inListCache.containsKey(valueList)) {
if (valueList.getValues().stream().allMatch(Literal.class::isInstance) &&
valueList.getValues().stream().noneMatch(NullLiteral.class::isInstance)) {
Set<Object> objectSet = valueList.getValues().stream().map(expression -> processWithExceptionHandling(expression, context)).collect(Collectors.toSet());
Type type = type(node.getValue());
set = FastutilSetHelper.toFastutilHashSet(
objectSet,
type,
plannerContext.getFunctionManager().getScalarFunctionInvoker(metadata.resolveOperator(session, HASH_CODE, ImmutableList.of(type)), simpleConvention(FAIL_ON_NULL, NEVER_NULL)).getMethodHandle(),
plannerContext.getFunctionManager().getScalarFunctionInvoker(metadata.resolveOperator(session, EQUAL, ImmutableList.of(type, type)), simpleConvention(NULLABLE_RETURN, NEVER_NULL, NEVER_NULL)).getMethodHandle());
}
inListCache.put(valueList, set);
}
inListCache.put(valueList, set);
}

if (set != null && !(value instanceof Expression)) {
return set.contains(value);
if (set != null) {
return set.contains(value);
}
}

boolean hasUnresolvedValue = value instanceof Expression;
Expand All @@ -633,6 +635,14 @@ protected Object visitInPredicate(InPredicate node, Object context)

ResolvedFunction equalsOperator = metadata.resolveOperator(session, OperatorType.EQUAL, types(node.getValue(), valueList));
for (Expression expression : valueList.getValues()) {
if (value instanceof Expression && expression instanceof Literal) {
Comment thread
sopel39 marked this conversation as resolved.
Outdated
// skip interpreting of literal IN term since it cannot be compared
// with unresolved "value" and it cannot be simplified further
values.add(expression);
types.add(type(expression));
continue;
}

// Use process() instead of processWithExceptionHandling() for processing in-list items.
// Do not handle exceptions thrown while processing a single in-list expression,
// but fail the whole in-predicate evaluation.
Expand Down Expand Up @@ -668,11 +678,11 @@ else if (!found && result) {
Type type = type(node.getValue());
List<Expression> expressionValues = toExpressions(values, types);
List<Expression> simplifiedExpressionValues = Stream.concat(
expressionValues.stream()
.filter(expression -> isDeterministic(expression, metadata))
.distinct(),
expressionValues.stream()
.filter((expression -> !isDeterministic(expression, metadata))))
expressionValues.stream()
.filter(expression -> isDeterministic(expression, metadata))
.distinct(),
expressionValues.stream()
.filter((expression -> !isDeterministic(expression, metadata))))
.collect(toImmutableList());

if (simplifiedExpressionValues.size() == 1) {
Expand Down