Improve IN list performance in ExpressionInterpreter#11902
Merged
sopel39 merged 3 commits intotrinodb:masterfrom Apr 14, 2022
Merged
Improve IN list performance in ExpressionInterpreter#11902sopel39 merged 3 commits intotrinodb:masterfrom
sopel39 merged 3 commits intotrinodb:masterfrom
Conversation
sopel39
force-pushed
the
ks/do_not_Create
branch
from
6e857ad to
0b3c7bf
Compare
Member
Author
|
Part of #5950 |
wendigo
approved these changes
Apr 11, 2022
sopel39
force-pushed
the
ks/do_not_Create
branch
3 times, most recently
from
c8e5e39 to
bbf7d17
Compare
findepi
reviewed
Apr 11, 2022
core/trino-main/src/main/java/io/trino/sql/planner/ExpressionInterpreter.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/ExpressionInterpreter.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/TestExpressionInterpreter.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Failed due to: #11825 |
sopel39
force-pushed
the
ks/do_not_Create
branch
from
bbf7d17 to
2544ed6
Compare
findepi
reviewed
Apr 12, 2022
core/trino-main/src/main/java/io/trino/sql/planner/ExpressionInterpreter.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/ExpressionInterpreter.java
Outdated
Show resolved
Hide resolved
Member
sopel39
force-pushed
the
ks/do_not_Create
branch
from
2544ed6 to
d455e18
Compare
findepi
reviewed
Apr 13, 2022
core/trino-main/src/main/java/io/trino/sql/planner/ExpressionInterpreter.java
Outdated
Show resolved
Hide resolved
sopel39
force-pushed
the
ks/do_not_Create
branch
2 times, most recently
from
e0ff5e9 to
4fb87a6
Compare
benchmarks before planLargeInQuery 2695,225ms/op after planLargeInQuery 2525,273ms/op
before planLargeInQuery 2525,273ms/op after planLargeInQuery 2260,965ms/op
sopel39
force-pushed
the
ks/do_not_Create
branch
from
4fb87a6 to
02ea077
Compare
sopel39
changed the title
Member
Author
|
I've removed preserving of Planner benchmark results: |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: