Fix LowCardinalityDictionaryWork in GroupByHash#11837
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Apr 7, 2022
Merged
Conversation
sopel39
approved these changes
Apr 7, 2022
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
skrzypo987
force-pushed
the
skrzypo/065-fix-low-cardinality-dictionary-work
branch
from
a35831f to
f98a127
Compare
Member
Author
|
Comments addressed |
pettyjamesm
approved these changes
Apr 7, 2022
Group ids assigned by GroupByHash#getGroupIds should be incremental as this is required by DistinctLimitOperator and MarkDistinctOperator to correctly recognize first occurence of unique row. This commit makes GetLowCardinalityDictionaryGroupIdsWork comply with this contract.
sopel39
force-pushed
the
skrzypo/065-fix-low-cardinality-dictionary-work
branch
from
f98a127 to
d778a63
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a fork of #11829 with added test
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:
Fixes #11776