Fix LowCardinalityDictionaryWork in GroupByHash#11829
Closed
pettyjamesm wants to merge 1 commit intotrinodb:masterfrom
Closed
Fix LowCardinalityDictionaryWork in GroupByHash#11829pettyjamesm wants to merge 1 commit intotrinodb:masterfrom
pettyjamesm wants to merge 1 commit intotrinodb:masterfrom
Conversation
pettyjamesm
force-pushed
the
fix-low-cardinality-dictionary-groupby-hash
branch
from
bc26e56 to
9f2d44b
Compare
sopel39
reviewed
Apr 6, 2022
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
pettyjamesm
force-pushed
the
fix-low-cardinality-dictionary-groupby-hash
branch
from
9f2d44b to
f73d77f
Compare
sopel39
reviewed
Apr 6, 2022
Member
sopel39
left a comment
sopel39
left a comment
There was a problem hiding this comment.
lgtm % test is needed % benchmark run
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
Outdated
Show resolved
Hide resolved
pettyjamesm
force-pushed
the
fix-low-cardinality-dictionary-groupby-hash
branch
from
f73d77f to
f561746
Compare
skrzypo987
approved these changes
Apr 7, 2022
Member
Author
|
Closing in favor of #11837 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where aggregations over
DictionaryBlockwith low cardinality could emit non-sequential groupId values, which would cause incorrect results inDistinctLimitOperatorandMarkDistinctHash.Fix for incorrect query results
Core engine
Fixes a correctness bug
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: