Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@
import static io.trino.plugin.hive.util.HiveUtil.isStructuralType;
import static io.trino.plugin.iceberg.ColumnIdentity.primitiveColumnIdentity;
import static io.trino.plugin.iceberg.ExpressionConverter.toIcebergExpression;
import static io.trino.plugin.iceberg.IcebergErrorCode.ICEBERG_FILESYSTEM_ERROR;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Code reformat -> Static import

import static io.trino.plugin.iceberg.IcebergErrorCode.ICEBERG_INVALID_METADATA;
import static io.trino.plugin.iceberg.IcebergSessionProperties.isProjectionPushdownEnabled;
import static io.trino.plugin.iceberg.IcebergSessionProperties.isStatisticsEnabled;
Expand Down Expand Up @@ -629,7 +630,7 @@ private void cleanExtraOutputFiles(HdfsContext hdfsContext, String queryId, Stri
}
}
catch (IOException e) {
throw new TrinoException(IcebergErrorCode.ICEBERG_FILESYSTEM_ERROR,
throw new TrinoException(ICEBERG_FILESYSTEM_ERROR,
format("Could not clean up extraneous output files; remaining files: %s", filesToDelete), e);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.util.List;
import java.util.Map;

import static com.google.common.base.MoreObjects.toStringHelper;
import static java.util.Objects.requireNonNull;

public class IcebergOptimizeHandle
Expand Down Expand Up @@ -97,4 +98,18 @@ public boolean isRetriesEnabled()
{
return retriesEnabled;
}

@Override
public String toString()
{
return toStringHelper(this)
.add("schemaAsJson", schemaAsJson)
.add("partitionSpecAsJson", partitionSpecAsJson)
.add("tableColumns", tableColumns)
.add("fileFormat", fileFormat)
.add("tableStorageProperties", tableStorageProperties)
.add("maxScannedFileSize", maxScannedFileSize)
.add("retriesEnabled", retriesEnabled)
.toString();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the meantime retriesEnabled was added to the class, add it to the toString too

}
}