Add toString to IcebergOptimizeHandle, static import in IcebergMetadata#11759
Merged
findepi merged 2 commits intotrinodb:masterfrom Apr 5, 2022
Merged
Conversation
8b788d9 to
3c0ad15
Compare
findepi
reviewed
Apr 4, 2022
Member
There was a problem hiding this comment.
generate the toString using Intellij, prefer Guava's toStringHelper (except in SPI where Guava is not on the pass, use StringJoiner there)
@Override
public String toString()
{
return toStringHelper(this)
.add("schemaAsJson", schemaAsJson)
.add("partitionSpecAsJson", partitionSpecAsJson)
.add("tableColumns", tableColumns)
.add("fileFormat", fileFormat)
.add("tableStorageProperties", tableStorageProperties)
.add("maxScannedFileSize", maxScannedFileSize)
.add("retriesEnabled", retriesEnabled)
.toString();
}
Member
There was a problem hiding this comment.
in the meantime retriesEnabled was added to the class, add it to the toString too
3c0ad15 to
d0265b2
Compare
findepi
approved these changes
Apr 4, 2022
losipiuk
reviewed
Apr 4, 2022
Member
There was a problem hiding this comment.
nit: Code reformat -> Static import
losipiuk
approved these changes
Apr 4, 2022
d0265b2 to
0ea885e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small changes that are necessary to implement expire_snapshots and delete_orpahn_files for iceberg.
Related issues, pull requests, and links
Documentation
(.) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(.) No release notes entries required.
( ) Release notes entries required with the following suggested text: