Fix flaky testWriteDifferentSizes#11678
Merged
losipiuk merged 1 commit intotrinodb:masterfrom Mar 28, 2022
Merged
Conversation
losipiuk
reviewed
Mar 27, 2022
plugin/trino-hive/src/test/java/io/trino/plugin/hive/BaseTestHiveOnDataLake.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Mar 27, 2022
Comment on lines
273
to
279
Member
There was a problem hiding this comment.
How are we sure that we will not get only small files if we end up having many writer tasks?
I am probably missing sth.
Member
Author
There was a problem hiding this comment.
My understanding even if we have multiple writer tasks, the distribution is still on a row-basis. Given that we write only one row, then there will be only one file.
Member
There was a problem hiding this comment.
Oh yeah - sure :) Makes total sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#11607 we assert that query produces three files with sizes in different ranges. However it turned out that it's not deterministic, as row distribution between writers is not deterministic.
This PR addresses the flakiness by writing only one large row that exercises different code paths of S3 streaming upload.
Increase test coverage
trino-hive
Related issues, pull requests, and links
Address #11659
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: