Increase test coverage for Hive S3 streaming upload#11607
Merged
losipiuk merged 1 commit intotrinodb:masterfrom Mar 24, 2022
Merged
Increase test coverage for Hive S3 streaming upload#11607losipiuk merged 1 commit intotrinodb:masterfrom
losipiuk merged 1 commit intotrinodb:masterfrom
Conversation
losipiuk
reviewed
Mar 22, 2022
Member
There was a problem hiding this comment.
Can you help me understand how a single test adds coverage for all 3 cases you mention in the commit message?
It would be worthy to add a comment in the code itself to explain what is happening. And also (if possible) an assertion which would validate that you tested exactly the case you wanted to.
Member
Author
There was a problem hiding this comment.
Addressed comments. This query writes three files whose sizes fall into the different ranges.
Added assertion for the file sizes, and a comment explanation.
arhimondr
approved these changes
Mar 23, 2022
Member
Author
|
Seems this test incurred an OOM. I will look into this. |
Add a test testInsertIntoPartitionedTableLargeFiles to exercise multiple code paths of S3 streaming upload, with upload part size 5MB: 1. file size <= 5MB (shortcut to direct upload) 2. file size > 5MB but <= 10MB (which triggered trinodb#10710) 3. file size > 10MB
losipiuk
approved these changes
Mar 24, 2022
Member
|
See #11659 -- the test is reported to be flaky |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test testInsertIntoPartitionedTableLargeFiles to exercise multiple code paths of S3 streaming upload, with part size 5MB:
The query will write three files, of sizes 15336718 bytes, 26283542 bytes and 33655242 bytes respectively.
Description
Improvement
trino-hive plugin test
This increases test coverage for our Hive S3 streaming upload path.
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: