Skip to content

Return 0 instead of row count in Cassandra completed bytes #11644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Mar 26, 2022
Merged

Return 0 instead of row count in Cassandra completed bytes #11644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions plugin/trino-cassandra/src/main/java/io/trino/plugin/cassandra/CassandraRecordCursor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ public class CassandraRecordCursor
private final List<CassandraType> cassandraTypes;
private final ResultSet rs;
private Row currentRow;
private long count;

public CassandraRecordCursor(CassandraSession cassandraSession, List<CassandraType> cassandraTypes, String cql)
{
Expand All @@ -48,7 +47,6 @@ public boolean advanceNextPosition()
{
if (!rs.isExhausted()) {
currentRow = rs.one();
count++;
return true;
}
return false;
Expand All @@ -68,7 +66,7 @@ public boolean getBoolean(int i)
@Override
public long getCompletedBytes()
{
return count;
return 0;
Copy link
Copy Markdown
Member

@findepi findepi Mar 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The io.trino.spi.connector.RecordCursor#getCompletedBytes's javadoc doesn't mention 0 as the special value.
In fact, it doesn't exist.

But, JDBC connectors do return 0.

Copy link
Copy Markdown
Member Author

@ebyhr ebyhr Mar 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me send another PR for javadoc. Also, I will fix MongoDB connector too.

}

@Override
Expand Down