Return 0 instead of row count in Cassandra completed bytes#11644
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Mar 26, 2022
Merged
Return 0 instead of row count in Cassandra completed bytes#11644ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
Cassandra Java driver doesn't expose the data size.
findepi
approved these changes
Mar 24, 2022
| public long getCompletedBytes() | ||
| { | ||
| return count; | ||
| return 0; |
Member
There was a problem hiding this comment.
The io.trino.spi.connector.RecordCursor#getCompletedBytes's javadoc doesn't mention 0 as the special value.
In fact, it doesn't exist.
But, JDBC connectors do return 0.
Member
Author
There was a problem hiding this comment.
Let me send another PR for javadoc. Also, I will fix MongoDB connector too.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Return 0 instead of row count in Cassandra completed bytes. Cassandra Java driver doesn't expose the data size.
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: