Skip to content

Fix source file's license header#11563

Merged
findepi merged 1 commit intotrinodb:masterfrom
findinpath:stats-rule-apache-license
Mar 18, 2022
Merged

Fix source file's license header#11563
findepi merged 1 commit intotrinodb:masterfrom
findinpath:stats-rule-apache-license

Conversation

@findinpath
Copy link
Copy Markdown
Contributor

@findinpath findinpath commented Mar 18, 2022

Description

Update the licensing header of the file to use Apache License

@cla-bot cla-bot bot added the cla-signed label Mar 18, 2022
@findinpath findinpath requested a review from findepi March 18, 2022 09:58
@findepi
Copy link
Copy Markdown
Member

findepi commented Mar 18, 2022

Thanks!
do you know why was this not caught by maven checks? cc @nineinchnick

@findinpath
Copy link
Copy Markdown
Contributor Author

Relevant PR where the class with the inappropriate licensing header was introduced #11197

@findinpath
Copy link
Copy Markdown
Contributor Author

          <groupId>com.mycila</groupId>
          <artifactId>license-maven-plugin</artifactId>
          <version>3.0</version>
          <executions>
            <execution>
              <phase>validate</phase>
              <goals>
                <goal>check</goal>
              </goals>
              <configuration>
                <skip>false</skip>
                <skipExistingHeaders>true</skipExistingHeaders>

From the project's effective pom.xml

So, I'm assuming that if the license header already exists (which it did in this case) the validator will not complain

@findepi findepi changed the title Use Apache License header Fix source file's license header Mar 18, 2022
@findepi findepi merged commit 8efc816 into trinodb:master Mar 18, 2022
@github-actions github-actions bot added this to the 375 milestone Mar 18, 2022
@martint
Copy link
Copy Markdown
Member

martint commented Mar 18, 2022

We had a similar issue before: #10812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants