Allow configuring if existing headers should be skipped in license check#303
Merged
findepi merged 1 commit intoairlift:masterfrom Mar 21, 2022
hashhar:hashhar/allow-configure-license-skip-existing-headers
Merged
Allow configuring if existing headers should be skipped in license check#303findepi merged 1 commit intoairlift:masterfrom hashhar:hashhar/allow-configure-license-skip-existing-headers
findepi merged 1 commit intoairlift:masterfrom
hashhar:hashhar/allow-configure-license-skip-existing-headers
Conversation
findepi
reviewed
Mar 18, 2022
| <configuration> | ||
| <skip>${air.check.skip-license}</skip> | ||
| <skipExistingHeaders>true</skipExistingHeaders> | ||
| <skipExistingHeaders>${air.license.skip-existing-headers}</skipExistingHeaders> |
Contributor
Author
There was a problem hiding this comment.
Just to preserve compatibility. IMO it should be false.
A case where this can be important is if you have mixed license files and want to preserve original licenses.
Member
There was a problem hiding this comment.
Let’s make this false, since that is the better default. Any projects that need to skip can set the property when updating.
Contributor
Author
There was a problem hiding this comment.
Updated default to true and adjusted CHANGES entry accordingly.
This behaviour can be controlled by the air.license.skip-existing-headers property.
findepi
approved these changes
Mar 21, 2022
hashhar
deleted the
hashhar/allow-configure-license-skip-existing-headers
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All credit to @findinpath for finding this.
See for source trinodb/trino#11563 (comment)
cc: @findinpath @findepi