Skip to content

Document PostgreSQL type mapping #11378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Mar 9, 2022
Merged

Document PostgreSQL type mapping #11378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions docs/src/main/sphinx/connector/postgresql.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,38 @@ catalog named ``sales`` using the configured connector.
Type mapping
------------

The data type mappings are as follows:

=================== ================================ =======================================================================
PostgreSQL Trino Notes
=================== ================================ =======================================================================
``BIT`` ``BOOLEAN``
Copy link
Copy Markdown
Member

@hashhar hashhar Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PostgreSQL has a real boolean type too.

Also do we properly handle bit(n) in the connector?

Copy link
Copy Markdown
Member Author

@ebyhr ebyhr Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also do we properly handle bit(n) in the connector?

I don't think so.

Copy link
Copy Markdown
Member

@hashhar hashhar Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#11384

``BOOLEAN`` ``BOOLEAN``
``SMALLINT`` ``SMALLINT``
``INTEGER`` ``INTEGER``
``BIGINT`` ``BIGINT``
Copy link
Copy Markdown
Member

@hashhar hashhar Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reminds that we should probably also test smallserial, serial and bigserial types too.

Copy link
Copy Markdown
Member

@hashhar hashhar Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#11385

``REAL`` ``DATE``
``DOUBLE`` ``DOUBLE``
``NUMERIC(p, s)`` ``DECIMAL(p, s)`` ``DECIMAL(p, s)`` is an alias of ``NUMERIC(p, s)``.
See :ref:`postgresql-decimal-type-handling` for more information.
``CHAR(n)`` ``CHAR(n)``
``VARCHAR(n)`` ``VARCHAR(n)``
``ENUM`` ``VARCHAR``
``BINARY`` ``VARBINARY``
``DATE`` ``DATE``
``TIME(n)`` ``TIME(n)``
``TIMESTAMP(n)`` ``TIMESTAMP(n)``
``TIMESTAMPTZ(n)`` ``TIMESTAMP(n) WITH TIME ZONE``
``MONEY`` ``VARCHAR``
``UUID`` ``UUID``
``JSON`` ``JSON``
``JSONB`` ``JSON``
``HSTORE`` ``MAP(VARCHAR, VARCHAR)``
``ARRAY`` Disabled, ``ARRAY`` or ``JSON`` See :ref:`postgresql-array-type-handling` for more information.
=================== ================================ =======================================================================

.. _postgresql-decimal-type-handling:

Decimal type handling
^^^^^^^^^^^^^^^^^^^^^

Expand All @@ -107,6 +139,8 @@ property, which can be set to ``UNNECESSARY`` (the default),
``UP``, ``DOWN``, ``CEILING``, ``FLOOR``, ``HALF_UP``, ``HALF_DOWN``, or ``HALF_EVEN``
(see `RoundingMode <https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/math/RoundingMode.html#enum.constant.summary>`_).

.. _postgresql-array-type-handling:

Array type handling
^^^^^^^^^^^^^^^^^^^

Expand Down