Improve PostgreSQL type mapping tests#11385
Merged
hashhar merged 2 commits intotrinodb:masterfrom Mar 9, 2022
Merged
Conversation
This commit includes: - Split testBasicTypes into separate tests - Add min/max/min-1/max+1 test cases for basic data types - Cover more tests using trinoCreateAndInsert - Reuse trinoCreateAndInsert
Member
Author
|
I'll send separate PR for moving to SqlDataTypeTest - catching some bugs while doing that. |
ebyhr
approved these changes
Mar 9, 2022
plugin/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlTypeMapping.java
Outdated
Show resolved
Hide resolved
6 tasks
hashhar
force-pushed
the
hashhar/pg-integer-type-tests
branch
from
08ec280 to
321b1dd
Compare
tangjiangling
approved these changes
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved type mapping tests + missing tests for serial types.
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.