Remove usage of static test classes in kuduconnectortests#11185
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Mar 2, 2022
Merged
Remove usage of static test classes in kuduconnectortests#11185ebyhr merged 2 commits intotrinodb:masterfrom
ebyhr merged 2 commits intotrinodb:masterfrom
Conversation
ebyhr
reviewed
Feb 24, 2022
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/connectortests/KuduVersion.java
Outdated
Show resolved
Hide resolved
...in/trino-kudu/src/test/java/io/trino/plugin/kudu/latestconnectortests/KuduLatestVersion.java
Outdated
Show resolved
Hide resolved
...in/trino-kudu/src/test/java/io/trino/plugin/kudu/latestconnectortests/KuduLatestVersion.java
Outdated
Show resolved
Hide resolved
...udu/src/test/java/io/trino/plugin/kudu/AbstractKuduWithStandardInferSchemaConnectorTest.java
Outdated
Show resolved
Hide resolved
Static inner test classes that did not follow the BaseConnectorTest naming convention were not being run. Rename tests to follow the naming convention and then fix the test error that was previously hidden
Static test classes with testng lead to unexpected behavior during test failures, switch to using top level classes instead
grantatspothero
force-pushed
the
gn/fixKuduTests
branch
from
2598818 to
fa2665a
Compare
grantatspothero
force-pushed
the
gn/fixKuduTests
branch
from
620ba43 to
48e315d
Compare
Contributor
Author
|
@ebyhr found 2 more problems, see the 2 new commits I pushed. The first is an actual race in the kudu connector code itself, the second is just a race in the test code. I'm going to create another PR for those 2 commits since they are unrelated to this PR. Note that means we will still have some flakes in this PR. #11264 |
Member
|
@grantatspothero Could you rebase on upstream to resolve conflicts in |
grantatspothero
force-pushed
the
gn/fixKuduTests
branch
2 times, most recently
from
fa2665a to
62dfc34
Compare
ebyhr
approved these changes
Mar 1, 2022
Member
|
Merged, thanks! |
hashhar
pushed a commit
to grantatspothero/trino
that referenced
this pull request
Mar 15, 2022
TestNG support for inner test classes is poor, see this issue: trinodb#11185
hashhar
pushed a commit
that referenced
this pull request
Mar 16, 2022
TestNG support for inner test classes is poor, see this issue: #11185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See here: #10940 (comment)
Static inner classes behave weirdly during some test failures, I'm not sure why but when the baseconnectortest naming convention test fails it causes the entire static inner class tests to not be run. Just breaking these static inner classes into separate top level classes.
Running stress tests then will remove the ci commit.
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.