Fix parquet data page offset calculation in parquet writer#10722
Merged
martint merged 1 commit intotrinodb:masterfrom Jan 24, 2022
Merged
Fix parquet data page offset calculation in parquet writer#10722martint merged 1 commit intotrinodb:masterfrom
martint merged 1 commit intotrinodb:masterfrom
Conversation
sauliusvl
changed the title
findepi
approved these changes
Jan 21, 2022
Member
|
@cla-bot check |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
|
The cla-bot has been summoned, and re-checked this pull request! |
Member
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Closed
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Feb 14, 2022
Cherry-pick of trinodb/trino#10722 The ParquetWriter::flush method calls int OutputStreamSliceOutput::size() to get the data page offset which is a long, thus flushing fails trying to write files larger than ~2 GB with an integer overflow exception. Co-authored-by: Saulius Valatka <saulius.vl@gmail.com>
pettyjamesm
pushed a commit
to prestodb/presto
that referenced
this pull request
Feb 18, 2022
Cherry-pick of trinodb/trino#10722 The ParquetWriter::flush method calls int OutputStreamSliceOutput::size() to get the data page offset which is a long, thus flushing fails trying to write files larger than ~2 GB with an integer overflow exception. Co-authored-by: Saulius Valatka <saulius.vl@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ParquetWriter::flushmethod callsint OutputStreamSliceOutput::size()to get the data page offset which is a long, thus flushing fails trying to write files larger than ~2 GB with an integer overflow exception (originating here).