Fix parquet data page offset calculation in parquet writer#17295
Merged
pettyjamesm merged 1 commit intoprestodb:masterfrom Feb 18, 2022
Merged
Fix parquet data page offset calculation in parquet writer#17295pettyjamesm merged 1 commit intoprestodb:masterfrom
pettyjamesm merged 1 commit intoprestodb:masterfrom
Conversation
Cherry-pick of trinodb/trino#10722 The ParquetWriter::flush method calls int OutputStreamSliceOutput::size() to get the data page offset which is a long, thus flushing fails trying to write files larger than ~2 GB with an integer overflow exception. Co-authored-by: Saulius Valatka <saulius.vl@gmail.com>
Contributor
Author
|
Failed test is unrelated. |
pettyjamesm
approved these changes
Feb 18, 2022
Contributor
pettyjamesm
left a comment
pettyjamesm
left a comment
There was a problem hiding this comment.
Looks good to me, let's see if we can get a green build
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of trinodb/trino#10722
The ParquetWriter::flush method calls int OutputStreamSliceOutput::size()
to get the data page offset which is a long, thus flushing fails trying
to write files larger than ~2 GB with an integer overflow exception.
Co-authored-by: Saulius Valatka saulius.vl@gmail.com