Use SqlDataTypeTest in MemSQL connector#10296
Merged
Conversation
Co-authored-by: Martijn Atema <martijn@atema.one> Co-authored-by: caillouc <48051170+caillouc@users.noreply.github.com> Co-authored-by: Linnea <62845882+linnea-bonnevier@users.noreply.github.com> Co-authored-by: Hallon <62335201+hallon-heyman@users.noreply.github.com> Co-authored-by: aoutir <61229034+aoutir@users.noreply.github.com>
hashhar
reviewed
Dec 16, 2021
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
Migration looks good. Some possible test improvements as comments.
Please apply all comments in separate commit since they are meant to increase coverage and not related to the migration to SqlDataTypeTest in any way.
plugin/trino-memsql/src/test/java/io/trino/plugin/memsql/TestMemSqlTypeMapping.java
Show resolved
Hide resolved
plugin/trino-memsql/src/test/java/io/trino/plugin/memsql/TestMemSqlTypeMapping.java
Show resolved
Hide resolved
plugin/trino-memsql/src/test/java/io/trino/plugin/memsql/TestMemSqlTypeMapping.java
Show resolved
Hide resolved
plugin/trino-memsql/src/test/java/io/trino/plugin/memsql/TestMemSqlTypeMapping.java
Show resolved
Hide resolved
hashhar
reviewed
Dec 16, 2021
plugin/trino-memsql/src/test/java/io/trino/plugin/memsql/TestMemSqlTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-memsql/src/test/java/io/trino/plugin/memsql/TestMemSqlTypeMapping.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/mmesql-mapping-test
branch
from
d991440 to
7327430
Compare
Additionally, leave a comment for a link to MemSQL data types.
ebyhr
force-pushed
the
ebi/mmesql-mapping-test
branch
from
7327430 to
ffb2275
Compare
grantatspothero
approved these changes
Dec 21, 2021
Contributor
grantatspothero
left a comment
grantatspothero
left a comment
There was a problem hiding this comment.
Thanks for doing this migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #7202 Fixes #6393