Conversation
ebyhr
force-pushed
the
ebi/memsql-time-type
branch
from
21676c4 to
602925e
Compare
ebyhr
requested review from
Praveen2112,
grantatspothero,
hashhar and
wendigo
plugin/trino-memsql/src/test/java/io/trino/plugin/memsql/TestMemSqlTypeMapping.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/memsql-time-type
branch
from
602925e to
769f476
Compare
grantatspothero
approved these changes
Dec 22, 2021
Contributor
grantatspothero
left a comment
grantatspothero
left a comment
There was a problem hiding this comment.
Thanks for adding the additional tests, LGTM 👍
hashhar
approved these changes
Dec 28, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.