Merged
Conversation
electrum
approved these changes
Dec 3, 2021
Contributor
|
@martint out of curiosity, how did you stumble on the exception you've mentioned in the description of the PR? |
Member
Author
|
I ran the CLI on an M1 Mac. Just tried again and this time it crashed with a SIGSEGV: |
|
Just tested and this fix works on Apple M1 systems. |
Member
|
Any chance this could be looked at again? |
Member
Author
I'm looking into some integration tests that started failing with this PR. |
Contributor
|
@martint this is a bug in jline: jline/jline3#751 Could be worked around by removing secondary line prompt in InputReader:
|
Contributor
|
Or: Works for me :) |
Member
Author
|
@wendigo, updated with your suggestion. Thanks! |
Fixes an incompatibility with ARM64:
com.sun.jna.LastErrorException: [14] Bad address
at com.sun.jna.Native.invokeVoid(Native Method)
at com.sun.jna.Function.invoke(Function.java:415)
at com.sun.jna.Function.invoke(Function.java:361)
at com.sun.jna.Library$Handler.invoke(Library.java:265)
at com.sun.proxy.$Proxy6.ioctl(Unknown Source)
at org.jline.terminal.impl.jna.osx.OsXNativePty.getSize(OsXNativePty.java:82)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an incompatibility with ARM64: