Skip to content

Support decimal encoding of NaN and Infinities values #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wendigo wants to merge 1 commit into from
Closed

Support decimal encoding of NaN and Infinities values #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions trino.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ def _trino_error_result(e: BaseException):
def _decimal_to_string(value: Decimal):
if not isinstance(value, Decimal):
raise ValueError('Not a Decimal: ' + type(value).__name__)
if not value.is_finite():
raise ValueError('Decimal is not finite: ' + str(value))
if value.is_nan():
return "NaN"
if value.is_infinite():
if value.is_signed():
return "-Infinity"
return "Infinity"
Comment on lines +48 to +52
Copy link
Copy Markdown
Member

@findepi findepi Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are valid values for Trino NUMBER but not for DECIMAL.
If we return NaN for decimal, this should fail somewhere later. I think for DECIMALs it's better to keep failing here

Copy link
Copy Markdown
Contributor Author

@wendigo wendigo Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since decimal is shared between decimal and number I think it's better to fail in Trino once nan or infinity is returned for Decimal

Copy link
Copy Markdown
Member

@findepi findepi Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a test for that:

return "{:f}".format(value)
Loading