Fail correctly when Python UDF decimal result overflows#28925
Merged
findepi merged 1 commit intotrinodb:masterfrom Mar 30, 2026
Merged
Conversation
findepi
added
the
no-release-notes
Python function runtime expect that `decimal.Decimal` is used when function result is mapped to SQL DECIMAL value. Python's `Decimal` supports non-finite values: NaN, -Infinity and +Infinity and values outside of SQL DECIMAL range. Add tests that TrinoException is correctly thrown when an non-mappable value is returned. For overflow this was not the case.
findepi
force-pushed
the
findepi/test-python-udf-with-non-finite-decimal-result-f657ef
branch
from
a6558ab to
cc61323
Compare
losipiuk
approved these changes
Mar 30, 2026
wendigo
approved these changes
Mar 30, 2026
findepi
deleted the
findepi/test-python-udf-with-non-finite-decimal-result-f657ef
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python function runtime expect that
decimal.Decimalis used when function result is mapped to SQL DECIMAL value. Python'sDecimalsupports non-finite values: NaN, -Infinity and +Infinity and values outside of SQL DECIMAL range.Add tests that TrinoException is correctly thrown when an non-mappable value is returned. For overflow this was not the case.