Skip to content

[tests] Fix TrinoDialect.has_schema arguments #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Oct 28, 2022
Merged

[tests] Fix TrinoDialect.has_schema arguments #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/integration/test_sqlalchemy_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def test_select_specific_columns(trino_connection):
@pytest.mark.parametrize('trino_connection', ['memory'], indirect=True)
def test_define_and_create_table(trino_connection):
engine, conn = trino_connection
if not engine.dialect.has_schema(engine, "test"):
if not engine.dialect.has_schema(conn, "test"):
engine.execute(sqla.schema.CreateSchema("test"))
metadata = sqla.MetaData()
try:
Expand Down Expand Up @@ -109,7 +109,7 @@ def test_define_and_create_table(trino_connection):
def test_insert(trino_connection):
engine, conn = trino_connection

if not engine.dialect.has_schema(engine, "test"):
if not engine.dialect.has_schema(conn, "test"):
engine.execute(sqla.schema.CreateSchema("test"))
metadata = sqla.MetaData()
try:
Expand Down Expand Up @@ -138,7 +138,7 @@ def test_insert(trino_connection):
@pytest.mark.parametrize('trino_connection', ['memory'], indirect=True)
def test_insert_multiple_statements(trino_connection):
engine, conn = trino_connection
if not engine.dialect.has_schema(engine, "test"):
if not engine.dialect.has_schema(conn, "test"):
engine.execute(sqla.schema.CreateSchema("test"))
metadata = sqla.MetaData()
users = sqla.Table('users',
Expand Down Expand Up @@ -322,7 +322,7 @@ def test_cte(trino_connection):
def test_json_column(trino_connection, json_object):
engine, conn = trino_connection

if not engine.dialect.has_schema(engine, "test"):
if not engine.dialect.has_schema(conn, "test"):
engine.execute(sqla.schema.CreateSchema("test"))
metadata = sqla.MetaData()

Expand Down Expand Up @@ -350,7 +350,7 @@ def test_json_column(trino_connection, json_object):
def test_get_table_comment(trino_connection):
engine, conn = trino_connection

if not engine.dialect.has_schema(engine, "test"):
if not engine.dialect.has_schema(conn, "test"):
engine.execute(sqla.schema.CreateSchema("test"))
metadata = sqla.MetaData()

Expand Down