[tests] Fix TrinoDialect.has_schema arguments #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
changed the title
hovaesco
approved these changes
Oct 14, 2022
mdesmet
approved these changes
Oct 27, 2022
Contributor
|
@hashhar : PTAL |
ebyhr
force-pushed
the
john-bodley--fix-tests-has-schema
branch
from
d702c75 to
389a3a9
Compare
ebyhr
approved these changes
Oct 28, 2022
Member
|
Merged, thanks! I fixed commit title. Please follow this guideline from next time. https://chris.beams.io/posts/git-commit/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is where type enforcement would be really helpful (see #208). For the SQLAlchemy dialect the
has_schemamethod was being passed the SQLAlchemy engine as opposed to the corresponding connection per here. Both objects have anexecute(...)method which is why the tests worked, however I thought it was prudent to make make sure the callers used the correct arguments.Non-technical explanation
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: