Skip to content

Bump coral to 2.2.49#5

Merged
electrum merged 1 commit into
trinodb:masterfrom
findinpath:findinpath/bump-coral-2.2.49
Oct 31, 2024
Merged

Bump coral to 2.2.49#5
electrum merged 1 commit into
trinodb:masterfrom
findinpath:findinpath/bump-coral-2.2.49

Conversation

@findinpath
Copy link
Copy Markdown
Contributor

@findinpath findinpath commented Oct 3, 2024

Overview of the past releases is available at
https://github.com/linkedin/coral/releases

How was the PR tested

Ran successfully locally on trinodb/trino the hive view translation product tests

testing/bin/ptl test run --environment multinode  -- -t io.trino.tests.product.hive.TestHiveViews
tests               | 2024-10-03 16:37:53 INFO: FAILURE     /    io.trino.tests.product.hive.TestHiveViewsLegacy.testViewReferencingHiveAndIcebergTables (Groups: hive_iceberg_redirections, profile_specific_tests) took 5.5 seconds
tests               | 2024-10-03 16:37:53 SEVERE: Failure cause:
tests               | io.trino.tempto.query.QueryExecutionException: java.sql.SQLException: Query failed (#20241003_105252_00220_fyhie): line 1:15: Failed analyzing stored view 'hive.default.hive_iceberg_view': Cannot query Iceberg table 'default.view_iceberg_table'
tests               | 	at io.trino.tempto.query.JdbcQueryExecutor.execute(JdbcQueryExecutor.java:119)
tests               | 	at io.trino.tempto.query.JdbcQueryExecutor.executeQuery(JdbcQueryExecutor.java:84)
tests               | 	at io.trino.tests.product.utils.QueryExecutors$1.lambda$executeQuery$0(QueryExecutors.java:54)
tests               | 	at dev.failsafe.Functions.lambda$toCtxSupplier$11(Functions.java:243)
tests               | 	at dev.failsafe.Functions.lambda$get$0(Functions.java:46)
tests               | 	at dev.failsafe.internal.RetryPolicyExecutor.lambda$apply$0(RetryPolicyExecutor.java:74)
tests               | 	at dev.failsafe.SyncExecutionImpl.executeSync(SyncExecutionImpl.java:187)
tests               | 	at dev.failsafe.FailsafeExecutor.call(FailsafeExecutor.java:376)
tests               | 	at dev.failsafe.FailsafeExecutor.get(FailsafeExecutor.java:112)
tests               | 	at io.trino.tests.product.utils.QueryExecutors$1.executeQuery(QueryExecutors.java:54)
tests               | 	at io.trino.tests.product.hive.AbstractTestHiveViews.testViewReferencingHiveAndIcebergTables(AbstractTestHiveViews.java:692)
...
tests               | 2024-10-03 16:34:51 INFO: FAILURE     /    io.trino.tests.product.hive.TestHiveViews.testViewReferencingHiveAndIcebergTables (Groups: hive_iceberg_redirections, profile_specific_tests) took 7.1 seconds
tests               | 2024-10-03 16:34:51 SEVERE: Failure cause:
tests               | io.trino.tempto.query.QueryExecutionException: java.sql.SQLException: Query failed (#20241003_104951_00074_fyhie): Failed to translate Hive view 'default.hive_iceberg_view': At line 0, column 0: Column 'an_integer' not found in table 'view_iceberg_table'
tests               | 	at io.trino.tempto.query.JdbcQueryExecutor.execute(JdbcQueryExecutor.java:119)
tests               | 	at io.trino.tempto.query.JdbcQueryExecutor.executeQuery(JdbcQueryExecutor.java:84)
tests               | 	at io.trino.tests.product.utils.QueryExecutors$1.lambda$executeQuery$0(QueryExecutors.java:54)
tests               | 	at dev.failsafe.Functions.lambda$toCtxSupplier$11(Functions.java:243)
tests               | 	at dev.failsafe.Functions.lambda$get$0(Functions.java:46)
tests               | 	at dev.failsafe.internal.RetryPolicyExecutor.lambda$apply$0(RetryPolicyExecutor.java:74)
tests               | 	at dev.failsafe.SyncExecutionImpl.executeSync(SyncExecutionImpl.java:187)
tests               | 	at dev.failsafe.FailsafeExecutor.call(FailsafeExecutor.java:376)
tests               | 	at dev.failsafe.FailsafeExecutor.get(FailsafeExecutor.java:112)
tests               | 	at io.trino.tests.product.utils.QueryExecutors$1.executeQuery(QueryExecutors.java:54)
tests               | 	at io.trino.tests.product.hive.AbstractTestHiveViews.testViewReferencingHiveAndIcebergTables(AbstractTestHiveViews.java:692)

....

tests               | 2024-10-03 16:38:54 INFO: 72 SUCCEEDED      /      2 FAILED      /      0 SKIPPED
tests               | 2024-10-03 16:38:54 INFO: Tests execution took 7 minutes and 8 seconds
tests               | 2024-10-03 16:38:54 INFO: ManageTestResources.onFinish: running checks
tests               | 
tests               | ===============================================
tests               | tempto-tests
tests               | Total tests run: 74, Failures: 2, Skips: 0
tests               | ===============================================

testing/bin/ptl test run --environment singlenode-hive-iceberg-redirections  -- -t io.trino.tests.product.hive.TestHiveViews.testViewReferencingHiveAndIcebergTables
tests               | ===============================================
tests               | tempto-tests
tests               | Total tests run: 1, Failures: 0, Skips: 0
tests               | ===============================================

Related issues and PRs

#2

@cla-bot cla-bot Bot added the cla-signed label Oct 3, 2024
@findinpath findinpath marked this pull request as ready for review October 3, 2024 11:20
@findinpath findinpath requested review from ebyhr and electrum October 3, 2024 11:24
@electrum electrum merged commit 05089f0 into trinodb:master Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants