Merged
Conversation
Contributor
Author
|
This PR is still in draft because the following regression was found while bumping up the dependency: Solved through linkedin/coral#467 |
Overview of the past releases is available at https://github.com/linkedin/coral/releases
findinpath
force-pushed
the
findinpath/bump-trino-coral
branch
from
686d9fe to
d7b1f6e
Compare
findepi
approved these changes
Oct 24, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of the past releases is available at
https://github.com/linkedin/coral/releases
Relevant releases:
[Coral-Trino] Avoid accidental translation of Trino from_unixtime SQL call - SqlFunction implementation [Coral-Trino] Avoid accidental translation of Trino
from_unixtimeSQL call - SqlFunction implementation linkedin/coral#467[Coral-Trino] [Backward Incompatible] Refactor RelToTrinoConverter API [Coral-Trino] [Backward Incompatible] Refactor RelToTrinoConverter API linkedin/coral#420
[Coral-Trino] Cast char fields, if necessary, to varchar type in the set operation - SqlCallTransformer [Coral-Trino] Cast char fields, if necessary, to varchar type in the set operation -
SqlCallTransformerlinkedin/coral#442Due to wrong coercion between varchar and char in Trino, as described in Change character literal treatment and char/varchar coercion trino#9031
, a work-around needs to be applied in case of translating Hive views which contain a UNION dealing with char and varchar types. The work-around consists in the explicit cast of the field having char type towards varchar type corresponding of the set operation output type.
How was the PR tested
Ran successfully locally on
trinodb/trinothe tests from the PR trinodb/trino#19275