Disallow rack 3 to be compatible with capybara #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails main allow rack 3 in rails/rails#46594. However, capybara doesn't support rack 3 yet. teamcapybara/capybara#2640 To test only for rails gem, lock rack version in 2.x.
tricknotes
force-pushed
the
fix-ci-rails-main
branch
from
de4f194
to
775b14e
Compare
This was referenced Feb 10, 2023
Merged
seanpdoyle
pushed a commit
that referenced
this pull request
Feb 18, 2024
This landed in #601 due to capybara incompatibility with rack 3. However, this issue has been solved in teamcapybara/capybara#2640.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails main allow rack 3 in rails/rails#46594. However, capybara doesn't support rack 3 yet. teamcapybara/capybara#2640
To test only for rails gem, lock rack version in 2.x.