Allow ember-cli-rails-assets < 1.0 #599
Conversation
|
@tricknotes I've pinged you on seanpdoyle/ember-cli-rails-assets#18 (comment), but you might not've received a notification since it's a different repository. |
|
@seanpdoyle This is a dependency issue. A new version of ember-cli-rails with this change will fix CI of seanpdoyle/ember-cli-rails-assets#18. To make ready this PR, I fixed rails main CI in #601. Could you review all of them? |
tricknotes
force-pushed
the
allow-ember-cli-rails-assets-0.7
branch
from
94f4101
to
e19de5e
Compare
|
Thanks for merge #601, @seanpdoyle ! |
ember-cli-rails.gemspec
Outdated
| @@ -15,7 +15,7 @@ Gem::Specification.new do |spec| | |||
|
|
|||
| spec.required_ruby_version = ">= 2.5.0" | |||
|
|
|||
| spec.add_dependency "ember-cli-rails-assets", "~> 0.6.2" | |||
| spec.add_dependency "ember-cli-rails-assets", ">= 0.6.2", "< 0.8" | |||
There was a problem hiding this comment.
What makes it important that the version is < 0.8?
There was a problem hiding this comment.
The reason for this is to prevent break due to dependency's breaking changes.
However, It can be more loose.
How do you think about changing it as "< 1.0"?
There was a problem hiding this comment.
Thanks for your reaction 👍
Updated e015ff1
It will be release in seanpdoyle/ember-cli-rails-assets#18.
tricknotes
force-pushed
the
allow-ember-cli-rails-assets-0.7
branch
from
e19de5e
to
e015ff1
Compare
tricknotes
changed the title
It will be release in seanpdoyle/ember-cli-rails-assets#18.