Skip to content

chore(suite-desktop): bump electron-builder#24753

Merged
Lemonexe merged 1 commit intodevelopfrom
chore/bump-electron-builder
Jan 28, 2026
Merged

chore(suite-desktop): bump electron-builder#24753
Lemonexe merged 1 commit intodevelopfrom
chore/bump-electron-builder

Conversation

@Lemonexe
Copy link
Copy Markdown
Contributor

@Lemonexe Lemonexe commented Jan 28, 2026 •
edited by trezor-bot Bot
Loading

Description

  • Bump electron-builder to 26.4.1, which already contains the hotfix for macOS plist settings needed to build Suite
  • Remove the app-builder-lib patch introduced in #24136
  • Remove the CI hotfixes introduced in #24310 and #24433 to cope with the patch.

Notes for QA

Suite Desktop builds & runs on all platforms, that can be tested as part of smoke tests.

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite desktop test results: View in Currents

@Lemonexe Lemonexe added the dependencies Pull requests that update a dependency file label Jan 28, 2026
@Lemonexe Lemonexe added this to Suite Jan 28, 2026
@Lemonexe Lemonexe added ci Continuous Integration (CI) related build-desktop This will trigger the build of desktop apps for your PR labels Jan 28, 2026
@Lemonexe Lemonexe moved this to 🔎 Needs review in Suite Jan 28, 2026
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Jan 28, 2026 •
edited
Loading

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • npm/electron-publish@26.4.1

View full report

@Lemonexe
Copy link
Copy Markdown
Contributor Author

Lemonexe commented Jan 28, 2026

@SocketSecurity ignore npm/electron-publish@26.4.1
We don't use electron-publish, and it is legitimate use anyway.

@Lemonexe Lemonexe marked this pull request as ready for review January 28, 2026 10:58
@Lemonexe Lemonexe merged commit 9f4ca9d into develop Jan 28, 2026
37 of 41 checks passed
@Lemonexe Lemonexe deleted the chore/bump-electron-builder branch January 28, 2026 11:54
@github-project-automation github-project-automation Bot moved this from 🔎 Needs review to 🤝 Needs QA in Suite Jan 28, 2026
@honzauher honzauher moved this from 🤝 Needs QA to 🧪 QA In progress in Suite Jan 29, 2026
@honzauher
Copy link
Copy Markdown
Contributor

honzauher commented Feb 6, 2026

QA OK based on RC sanity tests

Info:

  • Suite version: desktop 26.2.1 (843ba2b)
  • Browser: Trezor Suite 26.2.1
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T3W1 2.10.0 universal (revision de4b70e2e89a64f3894dba2124f6ec56e5cbd088)
  • Transport: BluetoothTransport, BridgeTransport 3.2.0

@honzauher honzauher moved this from 🧪 QA In progress to ✅ Approved in Suite Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peter-sanderson peter-sanderson peter-sanderson approved these changes

@komret komret Awaiting requested review from komret

@mroz22 mroz22 Awaiting requested review from mroz22 mroz22 is a code owner

@martykan martykan Awaiting requested review from martykan martykan is a code owner

@vdovhanych vdovhanych Awaiting requested review from vdovhanych vdovhanych is a code owner

Assignees

No one assigned

Labels

build-desktop This will trigger the build of desktop apps for your PR ci Continuous Integration (CI) related dependencies Pull requests that update a dependency file

Projects

Suite
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lemonexe @honzauher @peter-sanderson