Skip to content

chore(ci): organize patches desktop|native to fix yarn focus in CI#24310

Merged
Lemonexe merged 1 commit into
developfrom
fix/patch-package-with-focus
Jan 12, 2026
Merged

chore(ci): organize patches desktop|native to fix yarn focus in CI#24310
Lemonexe merged 1 commit into
developfrom
fix/patch-package-with-focus

Conversation

@Lemonexe
Copy link
Copy Markdown
Contributor

@Lemonexe Lemonexe commented Jan 12, 2026

Description

Fix native builds in CI

Build running here https://github.com/trezor/trezor-suite/actions/runs/20921238630 ✔️

Notes

This is bad. I wanted to something cleaner, more organized, but found no better solution 😞

npx patch-package is just not ready for yarn workspaces focus.
As per the docs there are flags for --include and --exclude but those are only for creating patches, sadly not for applying. That could be used for at least some degree of automation (organize patches into folders).

We could do npx patch-package PACKAGE_NAME and maintain lists in some plaintext file.

But idk, I think that patches are something that should not be considered permanent.
A 🐷 hotfix which I did for app-builder-lib is IMO fine, provided it is documented which I did, and removed later, which I take responsibility for. In any case, when removing the app-builder-lib entry from the md, the diff will show that hotfix is in place and should be removed.

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite desktop test results: View in Currents

@Lemonexe Lemonexe added ci Continuous Integration (CI) related no-project This label is used to specify that PR doesn't need to be added to a project labels Jan 12, 2026
@Lemonexe Lemonexe force-pushed the fix/patch-package-with-focus branch 2 times, most recently from a6467a7 to 066600d Compare January 12, 2026 12:07
@Lemonexe Lemonexe force-pushed the fix/patch-package-with-focus branch from 066600d to 80811e0 Compare January 12, 2026 12:11
@Lemonexe Lemonexe marked this pull request as ready for review January 12, 2026 12:12
@Lemonexe Lemonexe requested a review from vdovhanych as a code owner January 12, 2026 12:12
@Lemonexe Lemonexe had a problem deploying to develop-suite-native January 12, 2026 13:31 — with GitHub Actions Failure
Copy link
Copy Markdown
Member

@matejkriz matejkriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it, the patch is only temporary.

@Lemonexe Lemonexe merged commit ff04dbb into develop Jan 12, 2026
43 of 44 checks passed
@Lemonexe Lemonexe deleted the fix/patch-package-with-focus branch January 12, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration (CI) related no-project This label is used to specify that PR doesn't need to be added to a project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants